View Issue Details

IDProjectCategoryView StatusLast Update
0009802mantisbtattachmentspublic2020-09-19 10:53
Reporterrzuasti Assigned Tovboctor  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version1.1.4 
Target Version2.23.0Fixed in Version2.23.0 
Summary0009802: Support attachments associated with private notes
Description

I'm attaching a patch to allow private attachments upon issue update, it works exactly as private/public bugnotes and uses the same thresholds. There is a .sql in the package to alter the needed table in the database.

Tagspatch, schema

Relationships

related to 0021733 closedvboctor Attachments should be linkable to notes in db 
related to 0022817 closedvboctor "private bugnotes" as default setting prevents uploading further attachments 
has duplicate 0002461 closeddhx Private attachments 
has duplicate 0007533 closedatrol Upload File to be PRIVATE. 
has duplicate 0013207 closeddregad FEATURE REQUEST: Private attachment log in "issue history" 
has duplicate 0008367 closeddregad Set view status (private / public) for uploaded files 
has duplicate 0022303 closedvboctor When trying to add an attachement note status V_PRIVATE has effect (hide the attachment section) 
has duplicate 0022491 closeddregad Add Note - confusing behavior after View Status toggle is selected 
related to 0021843 closedvboctor Attachment dropzone missing from notes when the note is private 
related to 0024021 new Mark an attachment as outdated 
related to 0024831 closeddregad Unable to create private note 
related to 0025935 closedvboctor Warning for users when making public notes with attachments private 
related to 0026150 closedvboctor Closing issues via group action with empty note creates a bugnote record 
related to 0026631 closedvboctor file_get_visible_attachments shows private files that should be invisible to the user 
related to 0027039 closeddregad CVE-2020-25781: Access to private bug note attachments 

Activities

2008-11-11 08:38

 

jreese

jreese

2008-11-11 08:47

reporter   ~0019842

Last edited: 2008-11-11 08:47

Since the 1.1.x releases are not considered for feature upgrades, could you grab the latest snapshot of 1.2.x from http://git.mantisbt.org/?p=mantisbt.git;a=summary and resubmit a patch against that version?

Cheers.

rzuasti

rzuasti

2008-11-11 15:10

reporter   ~0019844

Find patch for 1.2.x latest snapshot attached.

rgds,
r.

2008-11-11 15:10

 

siebrand

siebrand

2009-01-12 18:32

developer   ~0020596

Can you please provide new patches based on git trunk (with context). 3 out of 4 patch files do not apply anymore.

C:\branches\mantisbt>patch core/bug_api.php core/bug_api.php.patch
patching file `core/bug_api.php'
Hunk 0000002 FAILED at 1394.
1 out of 2 hunks FAILED -- saving rejects to core/bug_api.php.rej

C:\branches\mantisbt>patch core/file_api.php core/file_api.php.patch
patching file `core/file_api.php'
Hunk 0000001 FAILED at 536.
Hunk 0000004 succeeded at 690 (offset 53 lines).
Hunk 0000005 FAILED at 692.
2 out of 5 hunks FAILED -- saving rejects to core/file_api.php.rej

C:\branches\mantisbt>patch bug_file_add.php bug_file_add.php.patch
patching file `bug_file_add.php'
Hunk 0000002 FAILED at 59.
1 out of 2 hunks FAILED -- saving rejects to bug_file_add.php.rej

C:\branches\mantisbt>patch bug_file_upload_inc.php bug_file_upload_inc.php.patc

patching file `bug_file_upload_inc.php'

2009-01-13 15:05

 

rzuasti

rzuasti

2009-01-13 15:06

reporter   ~0020611

It's done, see "patch20090113snapshot-privateAttachments.zip"

polzin

polzin

2010-02-15 05:25

reporter   ~0024391

What is the status of this? Are there chances that it comes into 1.2?

polzin

polzin

2010-12-07 09:40

reporter   ~0027565

So, could this go into 1.3? :-)

dregad

dregad

2016-11-04 09:33

developer   ~0054411

For the record, as I closed 0008367 as duplicate:
Forum discussion on this topic https://www.mantisbt.org/forums/viewtopic.php?f=2&t=2103

vboctor

vboctor

2019-07-22 01:45

manager   ~0062407

PR: https://github.com/mantisbt/mantisbt/pull/1529

Related Changesets

MantisBT: master 13d0f15d

2019-08-03 17:51:15

vboctor

Details Diff
Support private attachments with empty note Affected Issues
0009802, 0026150
mod - bugnote_add.php Diff File
mod - bugnote_view_inc.php Diff File
mod - core/bugnote_api.php Diff File