View Issue Details

IDProjectCategoryView StatusLast Update
0027828mantisbthtmlpublic2021-02-11 19:44
Reporterdregad Assigned Todregad  
PrioritynormalSeveritytweakReproducibilityN/A
Status resolvedResolutionfixed 
Target Version2.25.0Fixed in Version2.25.0 
Summary0027828: Standardize the way fontawesome icons are printed
Description

Currently, the code uses <i> tags to display fontawesome icons.

This should be replaced with a standard API to generate the HTML.

TagsNo tags attached.

Activities

Related Changesets

MantisBT: master 4431d285

2020-10-11 10:49:16

dregad

Details Diff
New generic icon_get() and print_icon() functions

Generates appropriate HTML tag to display a fontawesome icon, including
optional pop-up title and additional CSS classes.

Fixes 0027828
Affected Issues
0027828
mod - core/icon_api.php Diff File

MantisBT: master 5672b909

2020-10-11 11:29:55

dregad

Details Diff
Use new icon API functions - core

Replace hardcoded fontawesome <i> tags with new print_icon() or
icon_get() calls.

Fixes 0027828
Affected Issues
0027828
mod - core/bug_group_action_api.php Diff File
mod - core/classes/TimelineEvent.class.php Diff File
mod - core/columns_api.php Diff File
mod - core/custom_function_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/html_api.php Diff File
mod - core/layout_api.php Diff File
mod - core/logging_api.php Diff File
mod - core/prepare_api.php Diff File
mod - core/print_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/timeline_inc.php Diff File
mod - core/utility_api.php Diff File

MantisBT: master 09477d8f

2020-10-11 11:30:10

dregad

Details Diff
Use new icon API functions - plugins

Replace hardcoded fontawesome <i> tags with new print_icon() or
icon_get() calls.

Fixes 0027828
Affected Issues
0027828
mod - plugins/MantisCoreFormatting/pages/config.php Diff File
mod - plugins/MantisGraph/pages/category_graph.php Diff File
mod - plugins/MantisGraph/pages/developer_graph.php Diff File
mod - plugins/MantisGraph/pages/issues_trend_graph.php Diff File
mod - plugins/MantisGraph/pages/priority_graph.php Diff File
mod - plugins/MantisGraph/pages/reporter_graph.php Diff File
mod - plugins/MantisGraph/pages/resolution_graph.php Diff File
mod - plugins/MantisGraph/pages/severity_graph.php Diff File
mod - plugins/MantisGraph/pages/status_graph.php Diff File
mod - plugins/XmlImportExport/pages/config_page.php Diff File
mod - plugins/XmlImportExport/pages/import.php Diff File

MantisBT: master 28291f7f

2020-10-11 11:30:22

dregad

Details Diff
Use new icon API functions - admin & tests

Replace hardcoded fontawesome <i> tags with new print_icon() or
icon_get() calls.

Fixes 0027828
Affected Issues
0027828
mod - admin/db_stats.php Diff File
mod - admin/email_queue.php Diff File
mod - admin/index.php Diff File
mod - admin/move_attachments.php Diff File
mod - admin/move_attachments_page.php Diff File
mod - admin/system_utils.php Diff File
mod - admin/test_langs.php Diff File
mod - tests/Mantis/PrepareTest.php Diff File

MantisBT: master 5e509923

2020-10-11 11:33:47

dregad

Details Diff
Use new icon API functions

Replace hardcoded fontawesome <i> tags with new print_icon() or
icon_get() calls.

Fixes 0027828
Affected Issues
0027828
mod - account_page.php Diff File
mod - account_prefs_inc.php Diff File
mod - account_prof_edit_page.php Diff File
mod - account_prof_menu_page.php Diff File
mod - account_sponsor_page.php Diff File
mod - adm_config_page.php Diff File
mod - adm_config_report.php Diff File
mod - adm_permissions_report.php Diff File
mod - api_tokens_page.php Diff File
mod - billing_inc.php Diff File
mod - bug_actiongroup_page.php Diff File
mod - bug_change_status_page.php Diff File
mod - bug_relationship_graph.php Diff File
mod - bug_reminder_page.php Diff File
mod - bug_report_page.php Diff File
mod - bug_revision_view_page.php Diff File
mod - bug_sponsorship_list_view_inc.php Diff File
mod - bug_update_page.php Diff File
mod - bug_view_inc.php Diff File
mod - bugnote_add_inc.php Diff File
mod - bugnote_edit_page.php Diff File
mod - bugnote_stats_inc.php Diff File
mod - bugnote_view_inc.php Diff File
mod - changelog_page.php Diff File
mod - login_page.php Diff File
mod - login_password_page.php Diff File
mod - login_select_proj_page.php Diff File
mod - lost_pwd_page.php Diff File
mod - manage_columns_inc.php Diff File
mod - manage_config_email_page.php Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_workflow_page.php Diff File
mod - manage_custom_field_edit_page.php Diff File
mod - manage_custom_field_page.php Diff File
mod - manage_filter_edit_page.php Diff File
mod - manage_filter_page.php Diff File
mod - manage_overview_page.php Diff File
mod - manage_plugin_page.php Diff File
mod - manage_proj_cat_edit_page.php Diff File
mod - manage_proj_create_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File
mod - manage_proj_user_update.php Diff File
mod - manage_proj_ver_edit_page.php Diff File
mod - manage_tags_page.php Diff File
mod - manage_user_create_page.php Diff File
mod - manage_user_edit_page.php Diff File
mod - manage_user_page.php Diff File
mod - my_view_inc.php Diff File
mod - news_edit_page.php Diff File
mod - news_list_page.php Diff File
mod - news_menu_page.php Diff File
mod - proj_doc_add_page.php Diff File
mod - proj_doc_edit_page.php Diff File
mod - proj_doc_page.php Diff File
mod - query_store_page.php Diff File
mod - roadmap_page.php Diff File
mod - signup.php Diff File
mod - signup_page.php Diff File
mod - summary_page.php Diff File
mod - tag_update_page.php Diff File
mod - tag_view_page.php Diff File
mod - verify.php Diff File
mod - view_all_inc.php Diff File
mod - view_filters_page.php Diff File
mod - view_user_page.php Diff File

MantisBT: master b90cbcb4

2021-01-01 09:22:40

dregad

Details Diff
Modify icon_get()/print_icon() to allow inner HTML

Lets the caller insert HTML inside of the <i> tag generated by the
icon_get() function.

This can be used e.g. to inject a second icon next to the first, like
for the temporary filters.

Fixes 0027828
Affected Issues
0027828
mod - core/filter_api.php Diff File
mod - core/icon_api.php Diff File

MantisBT: master 92b63dfa

2021-01-08 10:46:06

atrol

Details Diff
Minor layout fixes after print icon changes

Issue 0027828
Affected Issues
0027828
mod - bugnote_view_inc.php Diff File

MantisBT: master 1c904c98

2021-01-31 11:29:02

dregad

Details Diff
Add missing space between status icon and select

Regression from 5e509923a9c58ec277f77c1e5ebc56ca147e6a61

Issue 0027828
Affected Issues
0027828
mod - bug_update_page.php Diff File

MantisBT: master 0595fb9b

2021-02-10 15:33:42

atrol

Details Diff
Add missing space between status icon and status value

Regression from 5e509923a9c58ec277f77c1e5ebc56ca147e6a61

Issue 0027828
Affected Issues
0027828
mod - core/columns_api.php Diff File

MantisBT: master 90597ded

2021-02-11 19:24:40

dregad

Details Diff
Stray `?>` tag causes PHP code to display

Regression introduced by 5e509923a9c58ec277f77c1e5ebc56ca147e6a61.

Fixes 0027828
Affected Issues
0027828
mod - bug_reminder_page.php Diff File