View Issue Details

IDProjectCategoryView StatusLast Update
0021701mantisbtuipublic2017-06-19 10:00
Reporterjoel Assigned Tojoel  
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Summary0021701: Notes always marked as private, if they are private by default
Description

When notes are set as private by default via the config below, the change status page would always mark notes as private even if the checkbox is unticked.

$g_default_bugnote_view_status = VS_PRIVATE;

Tagsmodern-ui

Activities

joel

joel

2016-09-20 03:58

developer   ~0054045

PR: https://github.com/mantisbt/mantisbt/pull/893

fman

fman

2017-06-19 09:59

reporter   ~0057097

my 5 cents:
<b>FROM</b>
$t_bug_note->view_state = gpc_get_bool( 'private', config_get( 'default_bugnote_view_status' ) == VS_PRIVATE ) ? VS_PRIVATE : VS_PUBLIC;

<b>TO</b>
$t_bug_note->view_state = VS_PUBLIC;
if( gpc_get_bool( 'private',VS_PUBLIC == VS_PRIVATE ) )
{
$t_bug_note->view_state = VS_PRIVATE;
}

fman

fman

2017-06-19 10:00

reporter   ~0057098

My 2 cents
FROM
$t_bug_note->view_state = gpc_get_bool( 'private', config_get( 'default_bugnote_view_status' ) == VS_PRIVATE ) ? VS_PRIVATE : VS_PUBLIC;

TO:
$t_bug_note->view_state = VS_PUBLIC;
if( gpc_get_bool( 'private',VS_PUBLIC == VS_PRIVATE ) )
{
$t_bug_note->view_state = VS_PRIVATE;
}