View Issue Details

IDProjectCategoryView StatusLast Update
0021619mantisbtcode cleanuppublic2017-02-26 21:17
Reporterdregad Assigned Todregad  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Target Version2.2.0Fixed in Version2.2.0 
Summary0021619: Use constants instead of hardcoded values for filter view types
Description

Throughout the code, we're using 'simple' and 'advanced' strings to reference the filter view types.

We should rely on constants instead.

TagsNo tags attached.

Relationships

related to 0017917 new Remove magic constants in filter_api.php / view_all_set.php 

Activities

Related Changesets

MantisBT: master 7a663f4a

2017-02-04 08:42:18

dregad

Details Diff
Use constants for filter view types

Define constants FILTER_VIEW_TYPE_SIMPLE and FILTER_VIEW_TYPE_ADVANCED
to reference filter view types, instead of relying on hardcoded strings
'simple' and 'advanced'.

Fixes 0021619
Affected Issues
0021619
mod - api/soap/mc_filter_api.php Diff File
mod - core/constant_inc.php Diff File
mod - core/filter_api.php Diff File
mod - core/filter_form_api.php Diff File
mod - manage_filter_edit_page.php Diff File
mod - plugins/MantisGraph/pages/issues_trend_bycategory_table.php Diff File
mod - plugins/MantisGraph/pages/issues_trend_bystatus_table.php Diff File
mod - search.php Diff File
mod - view_filters_page.php Diff File